Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SQLite3 may not throw DatabaseException #8467

Merged
merged 1 commit into from
Jan 30, 2024
Merged

fix: SQLite3 may not throw DatabaseException #8467

merged 1 commit into from
Jan 30, 2024

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Jan 27, 2024

Description
See #6913 (comment)

Use enableExceptions().
See https://www.php.net/manual/en/sqlite3.enableexceptions.php

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added bug Verified issues on the current code behavior or pull requests that will fix them 4.5 database Issues or pull requests that affect the database layer labels Jan 27, 2024
@kenjis kenjis mentioned this pull request Jan 27, 2024
Open
3 tasks
@kenjis kenjis marked this pull request as draft January 27, 2024 06:03
@kenjis kenjis marked this pull request as ready for review January 27, 2024 07:04
@kenjis kenjis force-pushed the fix-sqlite3-exception-not-thrown branch from cd5ab99 to 7e505b5 Compare January 28, 2024 00:34
@kenjis kenjis merged commit f673bb0 into codeigniter4:4.5 Jan 30, 2024
46 checks passed
@kenjis kenjis deleted the fix-sqlite3-exception-not-thrown branch January 30, 2024 23:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalsn michalsn michalsn approved these changes

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees
No one assigned
Labels
4.5 bug Verified issues on the current code behavior or pull requests that will fix them database Issues or pull requests that affect the database layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kenjis @michalsn @paulbalandan