Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: improve Forge variable names #8434

Merged
merged 22 commits into from
Jan 20, 2024
Merged

refactor: improve Forge variable names #8434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
0114c4d
refactor: rename variable names
kenjis Jan 18, 2024
6c18480
docs: make @var more detailed
kenjis Jan 18, 2024
c452ad0
docs: add PHPDocs
kenjis Jan 19, 2024
add3e07
style: break long line
kenjis Jan 19, 2024
4ac6ca5
refactor: rename variable names
kenjis Jan 19, 2024
f34fc58
refactor: rename variable names when DROP column
kenjis Jan 19, 2024
8924cb0
refactor: rename parameter name in _alterTable()
kenjis Jan 19, 2024
145e89a
docs: add @TODO
kenjis Jan 19, 2024
a33ff9c
docs: add PHPDoc types
kenjis Jan 19, 2024
3f56cc5
refactor: replace $data with $field
kenjis Jan 19, 2024
601ec58
docs: fix @phpstan-return
kenjis Jan 19, 2024
e14ca8b
style: break long line
kenjis Jan 19, 2024
bf30645
fix: incorrect refactoring
kenjis Jan 19, 2024
4d930fb
docs: fix @phpstan-return
kenjis Jan 19, 2024
1dd2e96
refactor: rename parameter name in Table::modifyColumn()
kenjis Jan 19, 2024
f097aeb
refactor: replace $field with $fields
kenjis Jan 19, 2024
b9c063f
style: break long line
kenjis Jan 19, 2024
3d4e12b
style: add empty lines
kenjis Jan 19, 2024
b8db96a
docs: remove duplicated if
kenjis Jan 19, 2024
ee10766
refactor: replace `! is_array()` with `is_string()`
kenjis Jan 19, 2024
04b6643
docs: fix @return types
kenjis Jan 19, 2024
213f0b9
refactor: add $columnNamesToDrop
kenjis Jan 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions phpstan-baseline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1451,11 +1451,6 @@
'count' => 1,
'path' => __DIR__ . '/system/Database/Postgre/Forge.php',
];
$ignoreErrors[] = [
'message' => '#^Return type \\(array\\|bool\\|string\\) of method CodeIgniter\\\\Database\\\\Postgre\\\\Forge\\:\\:_alterTable\\(\\) should be covariant with return type \\(array\\<string\\>\\|string\\|false\\) of method CodeIgniter\\\\Database\\\\Forge\\:\\:_alterTable\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Database/Postgre/Forge.php',
];
$ignoreErrors[] = [
'message' => '#^Construct empty\\(\\) is not allowed\\. Use more strict comparison\\.$#',
'count' => 1,
Expand Down Expand Up @@ -1656,11 +1651,6 @@
'count' => 1,
'path' => __DIR__ . '/system/Database/SQLite3/Forge.php',
];
$ignoreErrors[] = [
'message' => '#^Return type \\(array\\|string\\|null\\) of method CodeIgniter\\\\Database\\\\SQLite3\\\\Forge\\:\\:_alterTable\\(\\) should be covariant with return type \\(array\\<string\\>\\|string\\|false\\) of method CodeIgniter\\\\Database\\\\Forge\\:\\:_alterTable\\(\\)$#',
'count' => 1,
'path' => __DIR__ . '/system/Database/SQLite3/Forge.php',
];
$ignoreErrors[] = [
'message' => '#^Return type \\(SQLite3Result\\|false\\) of method CodeIgniter\\\\Database\\\\SQLite3\\\\PreparedQuery\\:\\:_getResult\\(\\) should be covariant with return type \\(object\\|resource\\|null\\) of method CodeIgniter\\\\Database\\\\BasePreparedQuery\\<SQLite3,SQLite3Stmt,SQLite3Result\\>\\:\\:_getResult\\(\\)$#',
'count' => 1,
Expand Down
Loading
Loading