New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Table class to fix phpstan errors #8402

Merged

kenjis merged 2 commits into codeigniter4:develop from kenjis:refactor-Table-phpstan-errors

Jan 6, 2024

Member

kenjis commented Jan 5, 2024 •

edited

Loading

Description

refactor to fix PHPStan error

Checklist:

Securely signed commits
Component(s) with PHPDoc blocks, only if necessary or adds value
Unit testing, with >80% coverage
User guide updated
Conforms to style guide

kenjis added 2 commits

January 5, 2024 19:09


          docs: make PHPDoc type more specific

c9798b6


          refactor: remove unneeded if condition

kenjis added the refactor label

michalsn approved these changes

View reviewed changes

kenjis merged commit 766f76b into codeigniter4:develop

50 of 61 checks passed

kenjis deleted the refactor-Table-phpstan-errors branch

January 6, 2024 00:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels