-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: spark make:test
creates test files in /tests/
directory v2
#8388
Conversation
f6ac660
to
9f25c39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
@@ -237,7 +239,7 @@ protected function getNamespaces() | |||
foreach ($this->autoloader->getNamespace() as $prefix => $paths) { | |||
foreach ($paths as $path) { | |||
if ($prefix === 'CodeIgniter') { | |||
$system = [ | |||
$system[] = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a functionally-impactful change. Was this a bug?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see: this is to enable both directories to map to \CodeIgniter\
. Could this cause other problems for existing code?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. The return value is originally an array list [['prefix' => prefix, 'path' => path], ...]
.
Adding an array for \CodeIgniter\
for test as a last element does no harm.
9f25c39
to
373bd9c
Compare
373bd9c
to
86696e9
Compare
Description
Supersedes #8374
make:test
creates test files in/tests/
directorytests/system
for namespaceCodeIgniter
E.g.,
If you set:
Checklist: