Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove deprecated Request::isValidIP() #8090

Merged
merged 4 commits into from
Oct 26, 2023
Merged

refactor: remove deprecated Request::isValidIP() #8090

merged 4 commits into from
Oct 26, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 25, 2023

Description

  • remove deprecated Request::isValidIP() and RequestInterface::isValidIP()

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code breaking change Pull requests that may break existing functionalities 4.5 labels Oct 25, 2023
@kenjis kenjis mentioned this pull request Oct 25, 2023
Merged
5 tasks
@kenjis kenjis merged commit 785995a into codeigniter4:4.5 Oct 26, 2023
46 checks passed
@kenjis kenjis deleted the remove-Request-isValidIP branch October 26, 2023 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5 breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner