Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: make IncomingRequest::$uri protected #8067

Merged
merged 2 commits into from
Oct 22, 2023
Merged

refactor: make IncomingRequest::$uri protected #8067

merged 2 commits into from
Oct 22, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Oct 20, 2023 •
edited
Loading

Needs #8057

Description
Fixes #5344

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@kenjis kenjis added refactor Pull requests that refactor code breaking change Pull requests that may break existing functionalities 4.5 labels Oct 20, 2023
@kenjis kenjis marked this pull request as draft October 20, 2023 08:39
@kenjis kenjis force-pushed the refactor-IncomingRequest-uri branch from 8709f51 to 9e05289 Compare October 22, 2023 05:43
@kenjis kenjis marked this pull request as ready for review October 22, 2023 05:43
MGatner
MGatner approved these changes Oct 22, 2023
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@kenjis kenjis merged commit 365e4c1 into codeigniter4:4.5 Oct 22, 2023
46 checks passed
@kenjis kenjis deleted the refactor-IncomingRequest-uri branch October 22, 2023 21:41
@kenjis kenjis mentioned this pull request Oct 27, 2023
Closed
@estherpeixoto estherpeixoto mentioned this pull request Apr 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MGatner MGatner MGatner approved these changes

@michalsn michalsn michalsn approved these changes

Assignees
No one assigned
Labels
4.5 breaking change Pull requests that may break existing functionalities refactor Pull requests that refactor code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kenjis @michalsn @MGatner