[Reverted] docs: fix event points descriptions #8055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kenjis
added
bug
kenjis
force-pushed
the
docs-fix-event-points
branch
from
c8898f0
to
82ccf15
Compare
MGatner
reviewed
Oct 20, 2023
| @@ -153,6 +153,12 @@ Hooks | |||
| - Instead of CI3's ``$hook['post_controller_constructor']`` you now use | |||
| ``Events::on('post_controller_constructor', ['MyClass', 'MyFunction']);``, with the namespace ``CodeIgniter\Events\Events;``. | |||
| - Events are always enabled, and are available globally. | |||
| - The hook point ``pre_controller`` and ``post_controller`` have been removed. | |||
There was a problem hiding this comment.
The source code, and the current docs.
$ grep -R Events::trigger system/
system//Database/BaseConnection.php: Events::trigger('DBQuery', $query);
system//Database/BaseConnection.php: Events::trigger('DBQuery', $query);
system//Database/BaseConnection.php: Events::trigger('DBQuery', $query);
system//Database/MigrationRunner.php: Events::trigger('migrate', $data);
system//Database/MigrationRunner.php: Events::trigger('migrate', $data);
system//Database/BasePreparedQuery.php: Events::trigger('DBQuery', $query);
system//Database/BasePreparedQuery.php: Events::trigger('DBQuery', $query);
system//Database/BasePreparedQuery.php: Events::trigger('DBQuery', $query);
system//Test/Mock/MockEmail.php: Events::trigger('email', $this->archive);
system//CodeIgniter.php: Events::trigger('pre_system');
system//CodeIgniter.php: Events::trigger('post_controller_constructor');
system//CodeIgniter.php: Events::trigger('post_system');
system//Email/Email.php: Events::trigger('email', $this->archive);
system//Email/Email.php: Events::trigger('email', $this->archive);
MGatner
approved these changes
Oct 22, 2023
|
Oh, v4.4.2 was already released! |
kenjis
changed the title
2 tasks
|
I created a new PR #8076 |
|
Sorry I missed that. New PR looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #8049
Checklist: