Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CLI prompt validation message #7977

Merged
merged 3 commits into from
Oct 10, 2023

Conversation

kenjis
Copy link
Member

@kenjis kenjis commented Sep 25, 2023

Description
Before:

$ php spark db:table

CodeIgniter v4.4.1 Command Line Tool - Server Time: 2023-09-25 23:24:52 UTC+00:00

Here is the list of your database tables:
  [0]  , CONCAT('',`password`) AS `email`
  [1]  blog
  [2]  migrations

Which table do you want to see? [0, 1, 2]: a
The Which table do you want to see? field must be one of: 0, 1, 2.

The last line is strange.

After:

$ php spark db:table

CodeIgniter v4.4.1 Command Line Tool - Server Time: 2023-09-25 23:25:26 UTC+00:00

Here is the list of your database tables:
  [0]  , CONCAT('',`password`) AS `email`
  [1]  blog
  [2]  migrations

Which table do you want to see? [0, 1, 2]: a
The "Which table do you want to see?" field must be one of: 0, 1, 2.

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the bug Verified issues on the current code behavior or pull requests that will fix them label Sep 25, 2023
@@ -448,7 +448,7 @@ public static function print(string $text = '', ?string $foreground = null, ?str
}

/**
* Outputs a string to the cli on it's own line.
* Outputs a string to the cli on its own line.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤗 Your English is great.

@kenjis kenjis merged commit eb1e7f6 into codeigniter4:develop Oct 10, 2023
61 checks passed
@kenjis kenjis deleted the fix-CLI-prompt-msg branch October 10, 2023 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Verified issues on the current code behavior or pull requests that will fix them
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants