Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dev: Remove the email ignore errors. #7773

Merged
merged 1 commit into from
Aug 4, 2023
+16 −40
Merged

Dev: Remove the email ignore errors. #7773

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 0 additions & 40 deletions phpstan-baseline.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -836,46 +836,6 @@
'count' => 2,
'path' => __DIR__ . '/system/Debug/Toolbar/Collectors/Views.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\Email\\\\Email\\:\\:SMTPEnd\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Email/Email.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\Email\\\\Email\\:\\:appendAttachments\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Email/Email.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\Email\\\\Email\\:\\:batchBCCSend\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Email/Email.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\Email\\\\Email\\:\\:buildHeaders\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Email/Email.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\Email\\\\Email\\:\\:buildMessage\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Email/Email.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\Email\\\\Email\\:\\:setErrorMessage\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Email/Email.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\Email\\\\Email\\:\\:unwrapSpecials\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Email/Email.php',
];
$ignoreErrors[] = [
'message' => '#^Method CodeIgniter\\\\Email\\\\Email\\:\\:writeHeaders\\(\\) has no return type specified\\.$#',
'count' => 1,
'path' => __DIR__ . '/system/Email/Email.php',
];
$ignoreErrors[] = [
'message' => '#^Static property CodeIgniter\\\\Email\\\\Email\\:\\:\\$func_overload \\(bool\\) in isset\\(\\) is not nullable\\.$#',
'count' => 1,
Expand Down
16 changes: 16 additions & 0 deletions system/Email/Email.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1064,6 +1064,8 @@ public function wordWrap($str, $charlim = null)

/**
* Build final headers
*
* @return void
*/
protected function buildHeaders()
{
Expand All @@ -1077,6 +1079,8 @@ protected function buildHeaders()

/**
* Write Headers as a string
*
* @return void
*/
protected function writeHeaders()
{
Expand All @@ -1103,6 +1107,8 @@ protected function writeHeaders()

/**
* Build Final Body and attachments
*
* @return void
*/
protected function buildMessage()
{
Expand Down Expand Up @@ -1263,6 +1269,8 @@ protected function attachmentsHaveMultipart($type)
* @param string $body Message body to append to
* @param string $boundary Multipart boundary
* @param string|null $multipart When provided, only attachments of this type will be processed
*
* @return void
*/
protected function appendAttachments(&$body, $boundary, $multipart = null)
{
Expand Down Expand Up @@ -1579,6 +1587,8 @@ public function send($autoClear = true)

/**
* Batch Bcc Send. Sends groups of BCCs in batches
*
* @return void
*/
public function batchBCCSend()
{
Expand Down Expand Up @@ -1623,6 +1633,8 @@ public function batchBCCSend()

/**
* Unwrap special elements
*
* @return void
*/
protected function unwrapSpecials()
{
Expand Down Expand Up @@ -1837,6 +1849,8 @@ protected function sendWithSmtp()

/**
* Shortcut to send RSET or QUIT depending on keep-alive
*
* @return void
*/
protected function SMTPEnd()
{
Expand Down Expand Up @@ -2156,6 +2170,8 @@ private function printDebuggerRaw(): string

/**
* @param string $msg
*
* @return void
*/
protected function setErrorMessage($msg)
{
Expand Down