Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Factories::define() to explicitly override a class #7733

Merged
merged 27 commits into from
Jul 29, 2023
Merged

feat: add Factories::define() to explicitly override a class #7733

merged 27 commits into from
Jul 29, 2023

Commits on Jul 26, 2023

  1. style: break long lines

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a8b528e View commit details
    Browse the repository at this point in the history

  2. refactor: extract isConfig()

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    85dd31b View commit details
    Browse the repository at this point in the history

  3. docs: add doc comments

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    79d3f35 View commit details
    Browse the repository at this point in the history

  4. feat: [BC] add Factories::define() to override module classes 

    Except for Config, if FQCN is specified, preferApp is ignored and that class is loaded.
    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d7ed053 View commit details
    Browse the repository at this point in the history

  5. chore: update psalm-baseline.xml for UndefinedClass

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    510c73f View commit details
    Browse the repository at this point in the history

  6. test: update failed test

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8629fdd View commit details
    Browse the repository at this point in the history

  7. fix: when injecting Config mock with Validation, register the same … 

    …instance as `Config\Validation`

When you call `Factories::injectMock('config', 'Validation', $config)`,
but if the production code calls `config(\Config\Validation::class)`,
the mock instance will not be used and fail the test:
CodeIgniter\Database\ModelFactoryTest::testBasenameReturnsExistingNamespaceInstance
    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    3f23901 View commit details
    Browse the repository at this point in the history

  8. style: remove empty line

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    86ca97b View commit details
    Browse the repository at this point in the history

  9. test: update failed test

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    74177ef View commit details
    Browse the repository at this point in the history

  10. fix: preferApp is used with short classname only

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    88bbbcf View commit details
    Browse the repository at this point in the history

  11. docs: introduce term "class alias" for docs

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    da9ea30 View commit details
    Browse the repository at this point in the history

  12. refactor: rename $basenames to $aliases

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    fd4d88c View commit details
    Browse the repository at this point in the history

  13. refactor: rename $name to $alias

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    0fac66c View commit details
    Browse the repository at this point in the history

  14. docs: improve doc comments

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    d385e98 View commit details
    Browse the repository at this point in the history

  15. refactor: extract isNamespaced()

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    8880351 View commit details
    Browse the repository at this point in the history

  16. docs: add @testtag

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a1fa03f View commit details
    Browse the repository at this point in the history

  17. refactor: use isNamespaced()

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    5b05bf9 View commit details
    Browse the repository at this point in the history

  18. refactor: use isNamespaced()

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    b482774 View commit details
    Browse the repository at this point in the history

  19. test: add test

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a3c768a View commit details
    Browse the repository at this point in the history

  20. docs: update comments

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    e3c223b View commit details
    Browse the repository at this point in the history

  21. refactor: extract getDefinedInstance()

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    244c5fb View commit details
    Browse the repository at this point in the history

  22. fix: remove logic for preferApp for no namespaced Config classname 

    preferApp should work only for no namespaced (Config) classname.
    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    340a930 View commit details
    Browse the repository at this point in the history

  23. docs: update existing description

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    a13c53d View commit details
    Browse the repository at this point in the history

  24. docs: add about Factories::define()

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    886fa87 View commit details
    Browse the repository at this point in the history

  25. docs: add changelog and upgrade guide

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    9fdd3f1 View commit details
    Browse the repository at this point in the history

  26. docs: fix typo

    @kenjis
    kenjis committed Jul 26, 2023
    Configuration menu
    Copy the full SHA
    c48b523 View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. docs: update existing descriptions

    @kenjis
    kenjis committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    89d6f37 View commit details
    Browse the repository at this point in the history