Skip to content

Fix deprecated usage of null on string params of internal functions #5371

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 25, 2021
Merged

Fix deprecated usage of null on string params of internal functions #5371

merged 1 commit into from
Nov 25, 2021

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Nov 21, 2021

Description
Related to #4883

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan mentioned this pull request Nov 21, 2021
Merged
15 tasks
@paulbalandan paulbalandan force-pushed the deprecated-null-on-internal-fn branch from a4876d0 to 78c18fd Compare November 21, 2021 11:47
MGatner
MGatner requested changes Nov 21, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only one I didn't look very closely at is Time, I can revisit if you get two other reviews.

@paulbalandan paulbalandan force-pushed the deprecated-null-on-internal-fn branch from 78c18fd to 4c50b10 Compare November 21, 2021 13:36
kenjis
kenjis reviewed Nov 22, 2021
View reviewed changes
kenjis
kenjis reviewed Nov 22, 2021
View reviewed changes
kenjis
kenjis reviewed Nov 22, 2021
View reviewed changes
kenjis
kenjis reviewed Nov 22, 2021
View reviewed changes
kenjis
kenjis reviewed Nov 22, 2021
View reviewed changes
kenjis
kenjis reviewed Nov 22, 2021
View reviewed changes
kenjis
kenjis reviewed Nov 22, 2021
View reviewed changes
kenjis
kenjis reviewed Nov 22, 2021
View reviewed changes
kenjis
kenjis reviewed Nov 22, 2021
View reviewed changes
kenjis
kenjis reviewed Nov 22, 2021
View reviewed changes
@paulbalandan paulbalandan force-pushed the deprecated-null-on-internal-fn branch from 4c50b10 to 8673228 Compare November 22, 2021 12:45
@kenjis kenjis merged commit e90d0c4 into codeigniter4:develop Nov 25, 2021
@paulbalandan paulbalandan deleted the deprecated-null-on-internal-fn branch November 25, 2021 03:16
@thiekus thiekus mentioned this pull request Dec 10, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @kenjis @MGatner