Fix precision loss deprecation on float to int conversion #5370
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGatner
approved these changes
Nov 21, 2021
sfadschm
reviewed
Nov 21, 2021
kenjis
approved these changes
Nov 22, 2021
paulbalandan
force-pushed
the
float-to-int-precision-loss
branch
from
5302549 to
147fc9d
Compare
Basically, yes. And we're just making it explicit now. Previously, because of loose typing, float got coerced to int implicitly but because this behavior is now deprecated, we're making it explicit to match with existing bahavior. If ever this would be buggy in the future, then we can adjust later. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #4883
Checklist: