Skip to content

docs: fix views.rst #5353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 22, 2021
Merged

docs: fix views.rst #5353

merged 4 commits into from
Nov 22, 2021

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Nov 18, 2021

Description

  • small fix

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • User guide updated
  • [] Conforms to style guide

@kenjis
docs: make view filename lowercase
d5c90f1 
Capital letters can also be used, but they are often lowercased.
@kenjis
docs: fix directory name
05ce8a5 
Saying that "If you have ``Blog`` directory", the directory name
must be Blog, not blog.
@kenjis kenjis added the documentation Pull requests for documentation only label Nov 18, 2021
paulbalandan
paulbalandan reviewed Nov 21, 2021
View reviewed changes
@kenjis
docs: replace blogview with blog_view
cb64680 
We use snake_case view filename, e.g. welcome_message, error_404.
@kenjis
docs: fix namespace directory explanation
7d15138
@kenjis kenjis requested a review from paulbalandan November 22, 2021 01:52
@paulbalandan paulbalandan merged commit 7ccba7f into codeigniter4:develop Nov 22, 2021
@kenjis kenjis deleted the fix-docs-views.rst branch November 22, 2021 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@paulbalandan paulbalandan paulbalandan approved these changes

Assignees

No one assigned

Labels

documentation Pull requests for documentation only

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kenjis @paulbalandan