Skip to content

Conversation

@kenjis
Copy link
Member

@kenjis kenjis commented Nov 18, 2021

Description
See #5344

There is no withUri() method in the Request, can't replace the code like:

$request->uri = new URI('http://example.com/assets/image.jpg');

Checklist:

  • Securely signed commits
  • [] Component(s) with PHPDoc blocks, only if necessary or adds value
  • [] Unit testing, with >80% coverage
  • [] User guide updated
  • Conforms to style guide

@kenjis kenjis added the refactor Pull requests that refactor code label Nov 18, 2021
@kenjis kenjis merged commit 03f5195 into codeigniter4:develop Nov 20, 2021
@kenjis kenjis deleted the refactor-request-uri branch November 20, 2021 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Pull requests that refactor code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants