Skip to content

Optimize builds #5255

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 30, 2021
Merged

Optimize builds #5255

merged 4 commits into from
Oct 30, 2021

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Oct 29, 2021

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

paulbalandan
paulbalandan commented Oct 29, 2021
View reviewed changes
kenjis
kenjis approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@kenjis kenjis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulbalandan paulbalandan merged commit 1d0b0d8 into codeigniter4:develop Oct 30, 2021
@paulbalandan paulbalandan deleted the optimize-builds branch October 30, 2021 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kenjis kenjis kenjis approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulbalandan @kenjis