Make the session handlers all compatible with SessionHandlerInterface #5012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulbalandan
force-pushed
the
session-handler-interface
branch
from
d869d4e to
8b60684
Compare
paulbalandan
force-pushed
the
session-handler-interface
branch
from
8b60684 to
0cbd332
Compare
michalsn
reviewed
Aug 19, 2021
MGatner
approved these changes
Aug 19, 2021
michalsn
approved these changes
Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #4883
Reference for the updated signatures: https://www.php.net/manual/en/class.sessionhandlerinterface.php
I've refactored and cleaned the code a bit as I see fit.
My only concern is for the
gcmethod. Our current implementation is using the pre-7.1 behavior where it returnstrueon success. Starting PHP 7.1, on success it should return the number of garbage collected sessions. My initial solution is to turntrueto1for handlers where the number can't easily be determined while returning the true number on others (like the file handler).Checklist: