Skip to content

Make CookieStore compatible with IteratorAggregate::getIterator #5010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

Make CookieStore compatible with IteratorAggregate::getIterator #5010

merged 1 commit into from
Aug 18, 2021

Conversation

@paulbalandan
Copy link
Member

Description
Related to #4883

Fatal error: During inheritance of IteratorAggregate: Uncaught Return type of CodeIgniter\Cookie\CookieStore::getIterator() should either be compatible with IteratorAggregate::getIterator(): Traversable, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Checklist:

  • Securely signed commits

@MGatner MGatner merged commit 148d78a into codeigniter4:develop Aug 18, 2021
@paulbalandan paulbalandan deleted the iterator-aggregate branch August 18, 2021 12:20
@paulbalandan paulbalandan mentioned this pull request Aug 19, 2021
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@paulbalandan @MGatner