Skip to content

Replace deprecated FILTER_SANITIZE_STRING #5005

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Replace deprecated FILTER_SANITIZE_STRING #5005

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions system/Router/RouteCollection.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ public function addPlaceholder($placeholder, ?string $pattern = null): RouteColl
*/
public function setDefaultNamespace(string $value): RouteCollectionInterface
{
$this->defaultNamespace = filter_var($value, FILTER_SANITIZE_STRING);
$this->defaultNamespace = esc(strip_tags($value));
$this->defaultNamespace = rtrim($this->defaultNamespace, '\\') . '\\';

return $this;
Expand All @@ -258,7 +258,7 @@ public function setDefaultNamespace(string $value): RouteCollectionInterface
*/
public function setDefaultController(string $value): RouteCollectionInterface
{
$this->defaultController = filter_var($value, FILTER_SANITIZE_STRING);
$this->defaultController = esc(strip_tags($value));

return $this;
}
Expand All @@ -269,7 +269,7 @@ public function setDefaultController(string $value): RouteCollectionInterface
*/
public function setDefaultMethod(string $value): RouteCollectionInterface
{
$this->defaultMethod = filter_var($value, FILTER_SANITIZE_STRING);
$this->defaultMethod = esc(strip_tags($value));

return $this;
}
Expand Down Expand Up @@ -1090,7 +1090,7 @@ protected function create(string $verb, string $from, $to, ?array $options = nul
$overwrite = false;
$prefix = $this->group === null ? '' : $this->group . '/';

$from = filter_var($prefix . $from, FILTER_SANITIZE_STRING);
$from = esc(strip_tags($prefix . $from));

// While we want to add a route within a group of '/',
// it doesn't work with matching, so remove them...
Expand Down