Skip to content

Make Cookie compatible with ArrayAccess #5004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

Make Cookie compatible with ArrayAccess #5004

merged 1 commit into from
Aug 18, 2021

Conversation

@paulbalandan
Copy link
Member

@paulbalandan paulbalandan commented Aug 17, 2021

Description
Related to #4883

During inheritance of ArrayAccess: Uncaught Return type of CodeIgniter\Cookie\Cookie::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[ReturnTypeWillChange] attribute should be used to temporarily suppress the notice

Checklist:

  • Securely signed commits

MGatner
MGatner approved these changes Aug 17, 2021
View reviewed changes
Copy link
Member

@MGatner MGatner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume these are all LSP-kosher.

@MGatner
Copy link
Member

MGatner commented Aug 17, 2021

My hunch is that this should go to 4.2 but that's not a strong opinion.

@paulbalandan
Copy link
Member Author

paulbalandan commented Aug 18, 2021

My take is this is not really a bug so it's fine to be in develop and the parent PR is in develop too.

@paulbalandan paulbalandan merged commit 5c8d1ae into codeigniter4:develop Aug 18, 2021
@paulbalandan paulbalandan deleted the cookie-array-access-8.1 branch August 18, 2021 02:31
@paulbalandan paulbalandan mentioned this pull request Aug 18, 2021
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn michalsn approved these changes

@MGatner MGatner MGatner approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@paulbalandan @MGatner @michalsn