-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NIO-7: Potential performance gains using offloading #91
Conversation
Provides potentially better performance. Signed-off-by: Markus KARG <[email protected]>
Provides potentially better performance. Signed-off-by: Markus KARG <[email protected]>
@rfscholte @hboutemy @olamy @bimargulies @khmarbaise Please review this PR. I would be glad if you would adopt this performance improvement. :-) |
What do I have to do to trigger merging? |
@olamy @gnodet @hboutemy @ezeeyahoo Why not merging this PR? |
@michael-o Thank you for the additional approval, but what is the process for actually merging the PR? |
Pushing the merge button. |
The button is not enabled for me. Seems I am missing the needed rights. What do I have to do to obtain them for the next time? |
I was referring to myself or other project committers ;-) |
How can I become a committer? I always wait for months for reactions upon my PRs, and I would like to be a more agile member of the team. |
I will try to add you. I have been contributing anyway in the last couple of years. But even if you are a committer we still prefer PRs for peer reviews. |
Thanks for adding me. Sure I will still file PRs for reviews, but in the end I can click merge three months earlier. ;-) |
This PR proposed the use of NIO-7 functionality to benefit from potential performance gains thanks to offloading to lower levels (JVM-internal solutions, OS-internal solutions, FS-internal solutions, etc.) instead of old-school File API.