-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always preserve dominant node value (even if empty) #217
Always preserve dominant node value (even if empty) #217
Conversation
I tested this against the Maven Integration Tests and there were no failures. |
Can you run this change against all Maven Plugin Tools ITs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This make sense. Requirement for merge is that MPT are running fine. Waiting for confirmation then I can merge.
You mean https://github.com/apache/maven-plugin-tools being build with |
Correct, this code must be in use for these ITs. |
@kwin Please rebase against master. |
@michael-o Actually this was thought as an alternative to #213 (as this includes blank values), but we can also obviously apply it on top. |
I see it as a compliment for #213 therefore a rebase is required. |
f112155
to
4f5e2f2
Compare
|
Build is successful with |
…in case it is empty (codehaus-plexus#216) This codehaus-plexus#216 and fixes codehaus-plexus#217
4f5e2f2
to
1d660b5
Compare
…in case it is empty (codehaus-plexus#216) This fixes codehaus-plexus#216 and closes codehaus-plexus#217
1d660b5
to
67ac243
Compare
This closes #216