The module name is not extracted when the path to the module contains spaces #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plamentotev
changed the title
rfscholte
reviewed
Feb 5, 2018
| @@ -78,7 +78,11 @@ public MainClassModuleNameExtractor( Path jdkHome ) | |||
|
|
|||
| for ( Path p : files.values() ) | |||
| { | |||
| argsWriter.append( p.toAbsolutePath().toString() ); | |||
| // make sure the path is surrounded with quotes in case there is space | |||
| argsWriter.append( "\"" ); | |||
There was a problem hiding this comment.
please replace with argsWriter.append( '"' ); on both lines
There was a problem hiding this comment.
Good catch. I've replaced both lines.
…ains spaces When `MainClassModuleNameExtractor` is run in external JVM a file with arguments for the JVM is created. This file contains the paths to the modules but if those paths contain spaces they are not properly escaped and as a result `MainClassModuleNameExtractor` receives corrupted paths as arguments. Quote all paths in the file so spaces are handled properly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When
MainClassModuleNameExtractoris run in external JVM a file with arguments for the JVM is created. This file contains the paths to the modules but if those paths contain spaces they are not properly escaped and as a resultMainClassModuleNameExtractorreceives corrupted paths as arguments.