-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use shared gh action #57
Conversation
jdk-matrix: '["11", "17"]' | ||
jdk-distribution-matrix: '["zulu", "temurin", "microsoft", "liberica"]' | ||
os-matrix: '["ubuntu-latest","windows-latest", "macOS-latest"]' | ||
maven_args: 'install javadoc:javadoc -e -B -V -fae ' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why need install?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why not? it's a temporary node so doesn't hurt anybody :)
jdk-fast-fail-build: '11' | ||
jdk-matrix: '["11", "17"]' | ||
jdk-distribution-matrix: '["zulu", "temurin", "microsoft", "liberica"]' | ||
os-matrix: '["ubuntu-latest","windows-latest", "macOS-latest"]' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the same as default
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
default has more jdks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@slawekjaranowski And default in master are changed without PRs neither asking around
No description provided.