Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure prompter does not double colon #10

Conversation

rmannibucau
Copy link
Contributor

No description provided.

Copy link
Member

@michael-o michael-o left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder whether the colon should be in the default reply at all. But it could also be a question so it is not our task to complete the sentence...

@rmannibucau
Copy link
Contributor Author

well fact is writePrompt (any prompt method) will always issue a ':' so any consumer of this API expects that but in defaultReply case it issues it twice which is a bug so the fix is sufficient. If we want to handle the question we need to add another promptQuestion method or something equivalent to enable to customize it but it is a new feature/API IMHO and this one would likely bypass the Prompter API to use the OutputHandler one directly.

@michael-o michael-o merged commit c3789ba into codehaus-plexus:master Feb 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants