add workaround to jdk bug https://bugs.openjdk.java.net/browse/JDK-8210649 found via https://issues.apache.org/jira/browse/MCOMPILER-346 add IT test from https://github.com/basil/MCOMPILER-346-mre #196
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…10649 found via https://issues.apache.org/jira/browse/MCOMPILER-346 add IT test from https://github.com/basil/MCOMPILER-346-mre Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
Signed-off-by: Olivier Lamy <[email protected]>
… it as it was not extensible here... :) Signed-off-by: Olivier Lamy <[email protected]>
![sonatype-lift[bot]](https://avatars.githubusercontent.com/in/9843?s=60&v=4){kind=small}
...exus-compiler-javac/src/main/java/org/codehaus/plexus/compiler/javac/JavaxToolsCompiler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Olivier Lamy <[email protected]>
olamy
commented
Mar 6, 2022
| @@ -111,14 +112,14 @@ public CompilerResult compileInProcess( String[] args, final CompilerConfigurati | |||
| CompilerMessage.Kind.ERROR ); | |||
| return new CompilerResult( false, Collections.singletonList( message ) ); | |||
| } | |||
| final String sourceEncoding = config.getSourceEncoding(); | |||
olamy
commented
Mar 6, 2022
| @@ -57,7 +58,7 @@ protected JavaCompiler newJavaCompiler() | |||
| return ToolProvider.getSystemJavaCompiler(); | |||
| } | |||
|
|
|||
| private List<JavaCompiler> JAVA_COMPILERS = new CopyOnWriteArrayList<>(); | |||
| private final List<JavaCompiler> JAVA_COMPILERS = new CopyOnWriteArrayList<>(); | |||
There was a problem hiding this comment.
a class field used in a synchronized block, this is the place where final is important and it was not there
olamy
commented
Mar 6, 2022
|
|
||
| public interface InProcessCompiler { | ||
| public interface InProcessCompiler extends LogEnabled { |
There was a problem hiding this comment.
I had to change that to be able to get logger.
The only usage of this in project is a manual construction of the only implementation available here and I bump version number.
olamy
commented
Mar 6, 2022
| import java.util.concurrent.CopyOnWriteArrayList; | ||
|
|
||
| /** | ||
| * @author Olivier Lamy | ||
| * @author <a href="mailto:[email protected]">David M. Lloyd</a> | ||
| * @since 2.0 | ||
| */ | ||
| @Component( role = Compiler.class ) | ||
| public class JavaxToolsCompiler implements InProcessCompiler | ||
| @Component( role = InProcessCompiler.class ) |
There was a problem hiding this comment.
not a change but fix a bug to be able to use dependency injection for this...
it was simply wrong for very long but the only usage was new JavaxToolsCompiler() :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Lamy [email protected]