-
Notifications
You must be signed in to change notification settings - Fork 3
Create dedicated Messages API #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Co-authored-by: laeubi <[email protected]>
Co-authored-by: laeubi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot see my review comments here for some changes, additionally we should mark the corresponding method in BuildContext as deprecated with a note to the new API to use.
src/main/java/org/codehaus/plexus/build/messages/DefaultMessages.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/build/messages/DefaultMessages.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/build/messages/MessageBuilder.java
Outdated
Show resolved
Hide resolved
src/main/java/org/codehaus/plexus/build/messages/DefaultMessages.java
Outdated
Show resolved
Hide resolved
…uctor, copyright removal, create(String message) Co-authored-by: laeubi <[email protected]>
Added @deprecated annotations to addMessage and removeMessages methods in BuildContext in commit 6a17a42. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@copilot just some smaller remarks
src/main/java/org/codehaus/plexus/build/messages/DefaultMessages.java
Outdated
Show resolved
Hide resolved
…ring() Co-authored-by: laeubi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, anyone else likes to review?
Otherwise I would Squash+Merge this the next days.
org.codehaus.plexus.build.messagesMessageTypeenum for message severity levels (INFO, WARNING, ERROR)Messageclass to hold message parametersMessageBuilderclass with builder pattern implementationMessagesinterface with clearAll, clear, and build methodsDefaultMessagesimplementation using BuildContextOriginal prompt
Fixes #102
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.