Port map to React #62
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johndeyrup
reviewed
Feb 19, 2021
johndeyrup
reviewed
Feb 19, 2021
snyderc
commented
Feb 19, 2021
| @@ -21,9 +21,14 @@ | |||
| "react" | |||
| ], | |||
| "rules": { | |||
| "template-curly-spacing": "off", | |||
There was a problem hiding this comment.
This is to fix an error TypeError: Cannot read property 'range' of null
Occurred while linting /Users/snyderc/Documents/vaccinatema/components/utilities/parseBookAppointmentString.js:1
hblumberg
approved these changes
Feb 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use React to render the map. Use CSS shapes instead of images for the stars and circles. Added URL parsing of the "booking" field on both the map and search. Took the elements from the current homepage so that we can render the current site homepage in React.
I kept the map and its subcomponents (marker, popup) in one file, because I think there will be changes to the organizational structure when we integrate the map into the search results page, which is the next step after publishing a Reactified version of the site.
Documentation for google-map-react:
https://github.com/google-map-react/google-map-react
https://github.com/google-map-react/google-map-react/blob/master/API.md