⚡️ Speed up method OpenAIToolsAgentComponent.create_agent_runnable by 11% in src/backend/base/langflow/components/langchain_utilities/openai_tools.py

[codeflash-ai]

📄 OpenAIToolsAgentComponent.create_agent_runnable in src/backend/base/langflow/components/langchain_utilities/openai_tools.py

✨ Performance Summary:

• Speed Increase: 📈 11% (0.11x faster)
• Runtime Reduction: ⏱️ From 25.0 milliseconds down to 22.6 milliseconds (best of 5 runs)

---

📝 Explanation and details

Certainly! Let's optimize the code by removing redundant checks and streamlining the logic where possible.

Improvements done.

• Removed the redundant check for 'input' in self.user_prompt by directly accessing it in a try-catch block to handle the KeyError which makes the logic cleaner.
• Reduced unnecessary line breaks.

This should perform slightly better due to streamlined error handling and efficient accessing of attributes.

---

✅ Correctness verification

The new optimized code was tested for correctness. The results are listed below:

Test	Status	Details
⚙️ Existing Unit Tests	🔘 None Found
🌀 Generated Regression Tests	✅ 4 Passed	See below
⏪ Replay Tests	🔘 None Found
🔎 Concolic Coverage Tests	🔘 None Found
📊 Coverage	100.0%

🌀 Generated Regression Tests Details

Click to view details

from unittest.mock import MagicMock, patch

# imports
import pytest  # used for our unit tests
# function to test
from langchain.agents import create_openai_tools_agent
from langchain_core.prompts import (ChatPromptTemplate,
                                    HumanMessagePromptTemplate, PromptTemplate)
from langflow.base.agents.agent import LCToolsAgentComponent
from langflow.components.langchain_utilities.openai_tools import \
    OpenAIToolsAgentComponent

# unit tests

# Basic Valid Input


def test_create_agent_runnable_no_input_key():
    component = OpenAIToolsAgentComponent()
    component.user_prompt = "Please provide details"
    component.system_prompt = "System message"
    component.llm = MagicMock()
    component.tools = MagicMock()
    
    with pytest.raises(ValueError, match="Prompt must contain 'input' key."):
        component.create_agent_runnable()

# Empty User Prompt
def test_create_agent_runnable_empty_user_prompt():
    component = OpenAIToolsAgentComponent()
    component.user_prompt = ""
    component.system_prompt = "System message"
    component.llm = MagicMock()
    component.tools = MagicMock()
    
    with pytest.raises(ValueError, match="Prompt must contain 'input' key."):
        component.create_agent_runnable()

# Null System Prompt










from unittest.mock import MagicMock

# imports
import pytest  # used for our unit tests
# function to test
from langchain.agents import create_openai_tools_agent
from langchain_core.prompts import (ChatPromptTemplate,
                                    HumanMessagePromptTemplate, PromptTemplate)
from langflow.base.agents.agent import LCToolsAgentComponent
from langflow.components.langchain_utilities.openai_tools import \
    OpenAIToolsAgentComponent

# unit tests

# Helper function to create a mock OpenAIToolsAgentComponent instance
def create_mock_component(user_prompt, system_prompt, llm=None, tools=None):
    component = OpenAIToolsAgentComponent()
    component.user_prompt = user_prompt
    component.system_prompt = system_prompt
    component.llm = llm if llm else MagicMock()
    component.tools = tools if tools else [MagicMock()]
    return component

# Basic Test Cases

def test_missing_input_key():
    component = create_mock_component(user_prompt={"not_input": "Test input"}, system_prompt="System prompt")
    with pytest.raises(ValueError, match="Prompt must contain 'input' key."):
        component.create_agent_runnable()





def test_non_string_user_prompt():
    component = create_mock_component(user_prompt={"input": 12345}, system_prompt="System prompt")
    with pytest.raises(TypeError):
        component.create_agent_runnable()

def test_non_string_system_prompt():
    component = create_mock_component(user_prompt={"input": "Test input"}, system_prompt=12345)
    with pytest.raises(TypeError):
        component.create_agent_runnable()










def test_different_encodings():
    component = create_mock_component(user_prompt={"input": "Test input".encode('utf-16')}, system_prompt="System prompt")
    with pytest.raises(TypeError):
        component.create_agent_runnable()

---

📣 **Feedback**

If you have any feedback or need assistance, feel free to join our Discord community: