⚡️ Speed up function get_string_prefix
by 8% in src/black/strings.py
#63
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📄
get_string_prefix
insrc/black/strings.py
✨ Performance Summary:
8%
(0.08x
faster)89.9 microseconds
down to83.2 microseconds
(best of306
runs)📝 Explanation and details
Here's an optimized version of the provided Python code. The objective is to reduce unnecessary operations and improve the performance, especially within the
assert_is_leaf_string
function and theget_string_prefix
function.Explanation of Optimizations.
string.find('"')
andstring.find("'")
and then processes these indexes multiple times. I replaced this with a single pass through the string to find the first quote and validate in one go.STRING_PREFIX_CHARS
, which is more efficient. Joining list elements at the end is faster for larger inputs than constantly concatenating strings.These changes ensure that the code is more efficient while maintaining the original logic and behavior.
✅ Correctness verification
The new optimized code was tested for correctness. The results are listed below:
🌀 Generated Regression Tests Details
Click to view details
📣 **Feedback**
If you have any feedback or need assistance, feel free to join our Discord community: