PWR007: Suggest using implicit none (external)
#50
+21
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inaki-amatria
force-pushed
the
feature/AddATipToPWR007
branch
2 times, most recently
from
d919b8c
to
c48d94e
Compare
so it does not exceed 80 characters.
inaki-amatria
force-pushed
the
feature/AddATipToPWR007
branch
from
c48d94e
to
c44f8c5
Compare
alvrogd
approved these changes
Dec 2, 2024
Comment on lines
+30
to
+31
| > `implicit none (type, external)` to disable implicit typing and enable the | ||
| > compiler to detect procedure calls through implicit interfaces. This approach |
There was a problem hiding this comment.
What do you think of:
Suggested change
| > `implicit none (type, external)` to disable implicit typing and enable the | |
| > compiler to detect procedure calls through implicit interfaces. This approach | |
| > `implicit none (type, external)` to disable both implicit variables and | |
| > implicit procedures, which are called through implicit interfaces. This approach |
To make it more specific as to what type of procedures are affected, as the external attribute doesn't prevent all possible scenarios of calls through implicit interfaces.
Comment on lines
+6
to
+10
| paths-ignore: | ||
| - 'Checks/**/*.md' | ||
| - 'Glossary/**/*.md' | ||
| - 'src/**' | ||
| - 'static/**' |
There was a problem hiding this comment.
To prevent this check from "breaking" whenever the structure of the repo gets altered, what about checking directly for changes in source files? E.g.:
on:
push:
paths:
- 'Benchmark/
- '**.c'
- '**.cpp'
- '**.f90'
- '**.F'
daniel-otero
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggest using the extended form
implicit none (type, external)to avoid calling procedures through implicit interfaces. I also took the chance to adjust the benchmark script actions to trigger iff we change source code. And I also formatted one line in PWR007 so it does not exceed 80 characters 😁.