-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Action generated with haskell-ci #1
Conversation
bd8a7ef
to
53fae37
Compare
strategy: | ||
matrix: | ||
include: | ||
- compiler: ghc-9.0.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd suggest testing GHC 9.2 as well at this point.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a compilation error with 9.2:
Error: cabal: Could not resolve dependencies:
@peterbecich I'm not sure why you're opening this against my fork, as I'm not the maintainer :P. The real repo is here: https://github.com/kubernetes-client/haskell/ FWIW, GitHub actions configs for Haskell can be much less verbose if you just use the Haskell setup actions that exist nowadays. For example: https://github.com/codedownio/sandwich/blob/master/.github/workflows/sandwich.yml |
@thomasjm , I think https://github.com/kubernetes-client/haskell/ currently only builds with GHC 8. So I was hoping to include this with your PR which fixes the build for GHC 9 in one step Good point, thanks, that is more concise, I wonder if there are still any advantages to using the generator https://github.com/haskell-CI/haskell-ci |
I'm already having trouble getting things merged over there haha, so making the PR larger isn't likely to help. I think you should probably cut out the middleman and open the PR directly against the main repo, where I'd be happy to review it. I've tested many projects with the Haskell setup actions and I think they work great. |
excellent points, thanks @thomasjm |
This is a GitHub Action for Cabal generated by https://github.com/haskell-CI/haskell-ci
The PR includes
cabal.project
to test all three projectsTest:
https://github.com/peterbecich/haskell-kubernetes-client/actions/runs/3683136262
GHC 8.10.7 fails
GHC 9.0.2 succeeds