Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove certfile and keyfile from APNS configurations #183

Merged
merged 3 commits into from
Jan 9, 2021

Conversation

hpopp
Copy link
Member

@hpopp hpopp commented Jan 9, 2021

Now configs should use the :cert and :key options by reading in the
raw contents of the file. This applies to both APNS.Config and
APNS.JWTConfig.

Also

  • Moved pigeon's application module from Pigeon to
    Pigeon.Application
  • Generated some valid (yet fake) certificates and keys for unit tests.

Now configs should use the `:cert` and `:key` options by reading in the
raw contents of the file. This applies to both `APNS.Config` and
`APNS.JWTConfig`.

Also
- Moved pigeon's application module from `Pigeon` to
  `Pigeon.Application`
- Generated some valid (yet fake) certificates and keys for unit tests.
Also: updated CHANGELOG with PR links
@hpopp hpopp merged commit 9d5de38 into master Jan 9, 2021
@hpopp hpopp deleted the feat/remove-certfile-keyfile branch January 9, 2021 19:48
@hpopp hpopp mentioned this pull request Jan 9, 2021
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant