Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CC-627 disable qunit require-expect rule #606

Merged
merged 2 commits into from
Jul 20, 2023
Merged

CC-627 disable qunit require-expect rule #606

merged 2 commits into from
Jul 20, 2023

Conversation

libmartinito
Copy link
Contributor

No description provided.

@linear
Copy link

linear bot commented Jul 20, 2023

CC-627 Fix lint error with new eslint-plugin-qunit

Here's the error: #597

[lint:js] /home/runner/work/frontend/frontend/tests/acceptance/pay-test.js
[lint:js]   16:3  error  Unexpected use of `assert.expect()` call  qunit/require-expect

I think the way we're using expect is reasonable - we're using it to check that the expect block gets called. There's a discussion about this here too: platinumazure/eslint-plugin-qunit#382.

Let's disable this rule (qunit/require-expect) for that specific usage + update the dependabot PR

@lintrule-review
Copy link

Checks passed

  • Ran no-bugs.md on tests/acceptance/pay-test.js

@libmartinito libmartinito merged commit 995c780 into master Jul 20, 2023
5 checks passed
@libmartinito libmartinito deleted the CC-627 branch July 20, 2023 14:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant