chore: don't save errors in LabelAnalysisRequest object
#99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the case where we have some missing information we were saving the errors as part of the result dict (in the database). There's a dedicated table for the larq errors, they should not be saved in the database. THese changes fix that adding the errors to the dict to return only after savign the real results.
Codecov Report
@@ Coverage Diff @@
## main #99 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 364 364
Lines 26826 26827 +1
=======================================
+ Hits 26420 26421 +1
Misses 406 406
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
joseph-sentry
approved these changes
Sep 15, 2023
giovanni-guidini
added a commit
to codecov/codecov-cli
that referenced
this pull request
Sep 19, 2023
codecov/worker#99 had the unwanted and overlooked effect of slightly changing the format of the response from Codecov label-analysis. Before the "errors" key was inside the "result" (it shouldn't be) So the CLI is not surfacing these errors anymore. These changes fix that and move the log line to a more logical position.
giovanni-guidini
added a commit
to codecov/codecov-cli
that referenced
this pull request
Sep 20, 2023
codecov/worker#99 had the unwanted and overlooked effect of slightly changing the format of the response from Codecov label-analysis. Before the "errors" key was inside the "result" (it shouldn't be) So the CLI is not surfacing these errors anymore. These changes fix that and move the log line to a more logical position.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case where we have some missing information we were saving the errors as part of the result dict (in the database).
There's a dedicated table for the larq errors, they should not be saved in the database.
THese changes fix that adding the errors to the dict to return only after savign the real results.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.