Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust logic for trialing customers monthly upload limit #92

Merged

Conversation

adrian-codecov
Copy link
Contributor

Uploads while undergoing a trial shouldn't affect the monthly uploads post trial. This is a code change to adjust this in the worker level

  • Adding logic to determine the monthly upload created date + tests
  • Adding some properties + tests to the plan service

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #92 (17c53d1) into main (b360665) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #92   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         362      362           
  Lines       26481    26517   +36     
=======================================
+ Hits        26077    26113   +36     
  Misses        404      404           
Flag Coverage Δ
integration 98.44% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.44% <100.00%> (+<0.01%) ⬆️
unit 98.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.13% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.24% <100.00%> (+<0.01%) ⬆️
Files Changed Coverage Δ
database/tests/factories/core.py 100.00% <100.00%> (ø)
services/decoration.py 100.00% <100.00%> (ø)
services/tests/test_decoration.py 96.14% <100.00%> (+0.35%) ⬆️
Related Entrypoints
run/app.tasks.notify.Notify

@adrian-codecov adrian-codecov merged commit 4a4bb80 into main Sep 7, 2023
11 of 12 checks passed
@adrian-codecov adrian-codecov deleted the 359-adjust-monthly-upload-limit-for-trialled-customers branch September 7, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants