Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add different comment message for 1st time pulls #89

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

scott-codecov
Copy link
Contributor

codecov/engineering-team#389

Companion PR to codecov/codecov-api#108

If a pull is the 1st for a repo then we want to show different copy in the PR comment.

@codecov
Copy link

codecov bot commented Sep 6, 2023

Codecov Report

Merging #89 (bca9aee) into main (c828650) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   98.47%   98.47%           
=======================================
  Files         362      362           
  Lines       26519    26549   +30     
=======================================
+ Hits        26115    26145   +30     
  Misses        404      404           
Flag Coverage Δ
integration 98.44% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.44% <100.00%> (+<0.01%) ⬆️
unit 98.44% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.13% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.24% <100.00%> (+<0.01%) ⬆️
Files Changed Coverage Δ
database/models/core.py 96.98% <100.00%> (+0.05%) ⬆️
...ervices/notification/notifiers/comment/__init__.py 99.43% <100.00%> (+0.01%) ⬆️
...cation/notifiers/tests/integration/test_comment.py 92.34% <100.00%> (+0.17%) ⬆️
.../notification/notifiers/tests/unit/test_comment.py 100.00% <100.00%> (ø)
tasks/tests/integration/test_notify_task.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

📢 Have feedback on the report? Share it here.

Copy link
Contributor

@giovanni-guidini giovanni-guidini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good in general. I like the welcome message.
Just left a couple of potentially silly questions, but it's honestly fine as is.

database/models/core.py Show resolved Hide resolved
services/notification/notifiers/comment/__init__.py Outdated Show resolved Hide resolved
services/notification/notifiers/comment/__init__.py Outdated Show resolved Hide resolved
@scott-codecov scott-codecov force-pushed the scott/first-pull branch 2 times, most recently from a8b4391 to e4c9df3 Compare September 8, 2023 16:13
@scott-codecov scott-codecov merged commit 8a59e46 into main Sep 8, 2023
11 of 12 checks passed
@scott-codecov scott-codecov deleted the scott/first-pull branch September 8, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants