Enable toggling for codecov slack app notifications #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-sentry
force-pushed
the
joseph/toggle-slack-app
branch
from
c24beab
to
71767d4
Compare
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #88 +/- ##
=======================================
Coverage 98.48% 98.48%
=======================================
Files 364 364
Lines 26818 26826 +8
=======================================
+ Hits 26412 26420 +8
Misses 406 406
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
force-pushed
the
joseph/toggle-slack-app
branch
from
71767d4
to
7556cd8
Compare
joseph-sentry
force-pushed
the
joseph/toggle-slack-app
branch
from
7556cd8
to
ff08642
Compare
joseph-sentry
requested review from
dana-yaish,
giovanni-guidini and
scott-codecov
dana-yaish
reviewed
Sep 12, 2023
| decoration_type=self.decoration_type, | ||
| ) | ||
| # yield notifier if slack_app field is True, nonexistent, or a non-empty dict | ||
| slack_app_yaml_field = read_yaml_field(self.current_yaml, ("slack_app",), True) |
There was a problem hiding this comment.
does this makes the slack app enabled by default?
dana-yaish
approved these changes
Sep 12, 2023
joseph-sentry
force-pushed
the
joseph/toggle-slack-app
branch
from
ff08642
to
8e9e6d1
Compare
This commit enables toggling for the slack app notifications via the codecov config slack_app option. Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
force-pushed
the
joseph/toggle-slack-app
branch
from
8e9e6d1
to
9968b87
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables toggling for the slack app notifications via the codecov config slack_app option.
Requires updating shared to use the new codecov schema containing the slack_app option.
Fixes: codecov/engineering-team#401
Depends on: codecov/shared#34