Use get_branch in get_behind_by instead of get_branches #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes get_behind_by to use get_branch instead of get_branches because of a GH API rate limiting issue. Instead of listing all branches in a repo via the API we now fetch only the one we are looking for, in this case the base branch of an open PR. This commit also makes changes to the requirements by updating shared to the latest version in order to use get_branch. Changes had to be made to existing integration tests as they we re-run, cassettes were updated. Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
requested review from
trent-codecov,
dana-yaish and
giovanni-guidini
Signed-off-by: joseph-sentry <[email protected]>
giovanni-guidini
approved these changes
Aug 30, 2023
Codecov Report
@@ Coverage Diff @@
## main #79 +/- ##
==========================================
- Coverage 98.59% 98.53% -0.07%
==========================================
Files 359 359
Lines 26333 26336 +3
==========================================
- Hits 25963 25949 -14
- Misses 370 387 +17
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
|
Signed-off-by: joseph-sentry <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes get_behind_by to use get_branch instead of get_branches because of a GH API rate limiting issue.
Instead of listing all branches in a repo via the API we now fetch only the one we are looking for, in this case the base branch of an open PR.
This commit also makes changes to the requirements by updating shared to the latest version in order to use get_branch.
Changes had to be made to existing integration tests as they we re-run, cassettes were updated.