fix: handle reports with line 0 executed #73
Conversation
Recently when testing the docs for integrating ATS I did [this commit](https://app.codecov.io/gh/giovanni-guidini/ats-data/commit/c24c1db8aa27fcda2d311fdcd293c20697030389) for which processing failed. Checking the logs it failed because of ``` [... removed stack trace...] File "/worker/services/report/languages/pycoverage.py", line 56, in process report_file.append( File "/usr/local/lib/python3.10/site-packages/shared/reports/resources.py", line 341, in append raise ValueError("Line number must be greater then 0. Got %s" % ln) ValueError: Line number must be greater then 0. Got 0 ``` Indeed when I donwloaded and checked the uploaded files there were 3 of them with `executed_lines: [0]`. They were all `__init__.py` files. Idk why that happened, to be honest. It looks strange because the 3 files are empty. In any case it's an easy fix that will not hurt us. I think line 0 should not exist. It might indicate that when importing the code or something like that the file was executed somehow, but for `__init__.py` files with some content in them the list of lines executed is as expected.
Codecov Report
@@ Coverage Diff @@
## main #73 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 359 359
Lines 26283 26284 +1
=======================================
+ Hits 25913 25914 +1
Misses 370 370
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
looks like executed_lines comes from coverage.py's json format, and far as i can tell, a line number of 0 is a bug in coverage.py
https://github.com/nedbat/coveragepy/blob/c2b238e86cade2e6163b24656a7d0549f4508e8f/coverage/sqldata.py#L937 this function appears to filter out 0s in one path but not the other. no idea what the root cause is of the 0s is, but i take that as evidence that 0s are not supposed to be returned
if you still have the bugged coverage.json, maybe file an issue on https://github.com/nedbat/coveragepy to let the author know
Recently when testing the docs for integrating ATS I did this commit
for which processing failed. Checking the logs it failed because of
Indeed when I donwloaded and checked the uploaded files there were 3 of them with
executed_lines: [0].They were all
__init__.pyfiles. Idk why that happened, to be honest. It looks strange because the 3 files are empty.In any case it's an easy fix that will not hurt us.
I think line 0 should not exist. It might indicate that when importing the code or something like that the file was
executed somehow, but for
__init__.pyfiles with some content in them the list of lines executed is as expected.Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.