Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add migrate.sh to worker #715

Merged
merged 3 commits into from
Sep 17, 2024
Merged

feat: add migrate.sh to worker #715

merged 3 commits into from
Sep 17, 2024

Conversation

joseph-sentry
Copy link
Contributor

No description provided.

adrian-codecov
adrian-codecov approved these changes Sep 17, 2024
View reviewed changes
Copy link
Contributor

@adrian-codecov adrian-codecov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As a future better way, we should add this script to Shared and use this for worker + api

adrian-codecov
adrian-codecov reviewed Sep 17, 2024
View reviewed changes
migrate.sh Outdated
@@ -0,0 +1,11 @@
#!/bin/sh

# Command ran by k8s to run migrations for api
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Worker instead of api

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   98.07%   97.92%   -0.15%     
==========================================
  Files         434      434              
  Lines       36734    36733       -1     
==========================================
- Hits        36027    35971      -56     
- Misses        707      762      +55
Flag Coverage Δ
integration 97.92% <100.00%> (-0.15%) ⬇️
latest-uploader-overall 97.92% <100.00%> (-0.15%) ⬇️
unit 97.92% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.96% <ø> (-0.01%) ⬇️
OutsideTasks 98.09% <ø> (ø)
Files Coverage Δ
tasks/test_results_processor.py 97.56% <ø> (-0.64%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 83.38% <100.00%> (-16.62%) ⬇️

@codecov-qa
Copy link

codecov-qa bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (b2c5405) to head (47ee581).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   98.07%   97.92%   -0.15%     
==========================================
  Files         434      434              
  Lines       36734    36733       -1     
==========================================
- Hits        36027    35971      -56     
- Misses        707      762      +55
Flag Coverage Δ
integration 97.92% <100.00%> (-0.15%) ⬇️
latest-uploader-overall 97.92% <100.00%> (-0.15%) ⬇️
unit 97.92% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.96% <ø> (-0.01%) ⬇️
OutsideTasks 98.09% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.56% <ø> (-0.64%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 83.38% <100.00%> (-16.62%) ⬇️

@codecov Codecov
Copy link

codecov bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (b2c5405) to head (47ee581).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   98.12%   97.97%   -0.15%     
==========================================
  Files         475      475              
  Lines       38089    38088       -1     
==========================================
- Hits        37374    37318      -56     
- Misses        715      770      +55
Flag Coverage Δ
integration 97.92% <100.00%> (-0.15%) ⬇️
latest-uploader-overall 97.92% <100.00%> (-0.15%) ⬇️
unit 97.92% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <ø> (-0.01%) ⬇️
OutsideTasks 98.09% <ø> (ø)
Files with missing lines Coverage Δ
tasks/test_results_processor.py 97.56% <ø> (-0.64%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 83.38% <100.00%> (-16.62%) ⬇️
Related Entrypoints
run/app.tasks.test_results.TestResultsProcessor

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Sep 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.92%. Comparing base (b2c5405) to head (47ee581).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #715      +/-   ##
==========================================
- Coverage   98.07%   97.92%   -0.15%     
==========================================
  Files         434      434              
  Lines       36734    36733       -1     
==========================================
- Hits        36027    35971      -56     
- Misses        707      762      +55
Flag Coverage Δ
integration 97.92% <100.00%> (-0.15%) ⬇️
latest-uploader-overall 97.92% <100.00%> (-0.15%) ⬇️
unit 97.92% <100.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.96% <ø> (-0.01%) ⬇️
OutsideTasks 98.09% <ø> (ø)
Files Coverage Δ
tasks/test_results_processor.py 97.56% <ø> (-0.64%) ⬇️
...sks/tests/unit/test_test_results_processor_task.py 83.38% <100.00%> (-16.62%) ⬇️

@joseph-sentry joseph-sentry added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit fa0e247 Sep 17, 2024
25 of 28 checks passed
@joseph-sentry joseph-sentry deleted the joseph/add-migrate-sh branch September 17, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrian-codecov adrian-codecov adrian-codecov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joseph-sentry @adrian-codecov