-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove parallel session_id allocations in Redis #711
Conversation
It looks like this code was incomplete, as it was *writing* to redis, but never *reading* from it.
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 98.09% 98.10%
=======================================
Files 434 434
Lines 36602 36625 +23
=======================================
+ Hits 35906 35930 +24
+ Misses 696 695 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 98.09% 98.10%
=======================================
Files 434 434
Lines 36602 36625 +23
=======================================
+ Hits 35906 35930 +24
+ Misses 696 695 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #711 +/- ##
=======================================
Coverage 98.09% 98.10%
=======================================
Files 434 434
Lines 36602 36625 +23
=======================================
+ Hits 35906 35930 +24
+ Misses 696 695 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Changes have been made to critical files, which contain lines commonly executed in production. Learn more ✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #711 +/- ##
==========================================
+ Coverage 98.14% 98.15% +0.01%
==========================================
Files 475 475
Lines 37957 38348 +391
==========================================
+ Hits 37252 37641 +389
- Misses 705 707 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes
|
It looks like this code was incomplete, as it was writing to redis, but never reading from it.