Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove parallel session_id allocations in Redis #711

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Swatinem
Copy link
Contributor

It looks like this code was incomplete, as it was writing to redis, but never reading from it.

It looks like this code was incomplete, as it was *writing* to redis, but never *reading* from it.
@Swatinem Swatinem requested a review from a team September 16, 2024 13:55
@Swatinem Swatinem self-assigned this Sep 16, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   98.09%   98.10%           
=======================================
  Files         434      434           
  Lines       36602    36625   +23     
=======================================
+ Hits        35906    35930   +24     
+ Misses        696      695    -1     
Flag Coverage Δ
integration 98.10% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.10% <100.00%> (+<0.01%) ⬆️
unit 98.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.11% <ø> (+0.01%) ⬆️
Files Coverage Δ
services/redis.py 92.30% <ø> (-1.03%) ⬇️
services/report/__init__.py 98.00% <ø> (+0.64%) ⬆️
tasks/flush_repo.py 95.45% <ø> (-0.28%) ⬇️
tasks/upload.py 96.32% <100.00%> (-0.04%) ⬇️

... and 3 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (10c910a) to head (b947ecc).
Report is 7 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   98.09%   98.10%           
=======================================
  Files         434      434           
  Lines       36602    36625   +23     
=======================================
+ Hits        35906    35930   +24     
+ Misses        696      695    -1     
Flag Coverage Δ
integration 98.10% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.10% <100.00%> (+<0.01%) ⬆️
unit 98.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.11% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
services/redis.py 92.30% <ø> (-1.03%) ⬇️
services/report/__init__.py 98.00% <ø> (+0.64%) ⬆️
tasks/flush_repo.py 95.45% <ø> (-0.28%) ⬇️
tasks/upload.py 96.32% <100.00%> (-0.04%) ⬇️

... and 3 files with indirect coverage changes

Copy link

codecov-public-qa bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.10%. Comparing base (10c910a) to head (b947ecc).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #711   +/-   ##
=======================================
  Coverage   98.09%   98.10%           
=======================================
  Files         434      434           
  Lines       36602    36625   +23     
=======================================
+ Hits        35906    35930   +24     
+ Misses        696      695    -1     
Flag Coverage Δ
integration 98.10% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.10% <100.00%> (+<0.01%) ⬆️
unit 98.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.02% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.11% <ø> (+0.01%) ⬆️
Files Coverage Δ
services/redis.py 92.30% <ø> (-1.03%) ⬇️
services/report/__init__.py 98.00% <ø> (+0.64%) ⬆️
tasks/flush_repo.py 95.45% <ø> (-0.28%) ⬇️
tasks/upload.py 96.32% <100.00%> (-0.04%) ⬇️

... and 3 files with indirect coverage changes

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (10c910a) to head (b947ecc).
Report is 7 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #711      +/-   ##
==========================================
+ Coverage   98.14%   98.15%   +0.01%     
==========================================
  Files         475      475              
  Lines       37957    38348     +391     
==========================================
+ Hits        37252    37641     +389     
- Misses        705      707       +2     
Flag Coverage Δ
integration 98.10% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.10% <100.00%> (+<0.01%) ⬆️
unit 98.10% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.14% <100.00%> (+0.02%) ⬆️
OutsideTasks 98.11% <ø> (+0.01%) ⬆️
Files with missing lines Coverage Δ
services/redis.py 92.30% <ø> (-1.03%) ⬇️
services/report/__init__.py Critical 98.00% <ø> (+0.64%) ⬆️
tasks/flush_repo.py 95.45% <ø> (-0.28%) ⬇️
tasks/upload.py Critical 97.67% <100.00%> (-0.03%) ⬇️

... and 3 files with indirect coverage changes

Related Entrypoints
run/app.tasks.upload.Upload
run/app.tasks.upload.PreProcessUpload
run/app.tasks.flush_repo.FlushRepo

@Swatinem Swatinem added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit e3cb698 Sep 17, 2024
26 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/no-redis-sessionid branch September 17, 2024 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants