Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: WORKER-P8R #702

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: WORKER-P8R #702

merged 1 commit into from
Sep 11, 2024

Conversation

giovanni-guidini
Copy link
Contributor

For the commit_status context it's possible that the pull is None (which is not the case for comment). I forgot to include that check.

This really shows that:
(1) the builders pattern is not very good, because of code duplication, and
(2) we need better tests

But for now this only fixes issue worker-p8r

For the `commit_status` context it's possible that the `pull` is `None` (which is not the case for `comment`). I forgot to include that check.

This really shows that:
(1) the builders pattern is not very good, because of code duplication, and
(2) we need better tests

But for now this only fixes issue worker-p8r
@giovanni-guidini giovanni-guidini requested a review from a team September 11, 2024 12:55
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   98.09%   98.09%   -0.01%     
==========================================
  Files         434      434              
  Lines       36600    36610      +10     
==========================================
+ Hits        35904    35913       +9     
- Misses        696      697       +1     
Flag Coverage Δ
integration 98.09% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.09% <100.00%> (-0.01%) ⬇️
unit 98.09% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.10% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
...s/bundle_analysis/notify/contexts/commit_status.py 100.00% <100.00%> (ø)
...otify/contexts/tests/test_commit_status_context.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (dcea64a) to head (1b738ea).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   98.09%   98.09%   -0.01%     
==========================================
  Files         434      434              
  Lines       36600    36610      +10     
==========================================
+ Hits        35904    35913       +9     
- Misses        696      697       +1     
Flag Coverage Δ
integration 98.09% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.09% <100.00%> (-0.01%) ⬇️
unit 98.09% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.10% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...s/bundle_analysis/notify/contexts/commit_status.py 100.00% <100.00%> (ø)
...otify/contexts/tests/test_commit_status_context.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

codecov-public-qa bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.09%. Comparing base (dcea64a) to head (1b738ea).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   98.09%   98.09%   -0.01%     
==========================================
  Files         434      434              
  Lines       36600    36610      +10     
==========================================
+ Hits        35904    35913       +9     
- Misses        696      697       +1     
Flag Coverage Δ
integration 98.09% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.09% <100.00%> (-0.01%) ⬇️
unit 98.09% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.10% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
...s/bundle_analysis/notify/contexts/commit_status.py 100.00% <100.00%> (ø)
...otify/contexts/tests/test_commit_status_context.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (dcea64a) to head (1b738ea).
Report is 2 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #702      +/-   ##
==========================================
- Coverage   98.14%   98.14%   -0.01%     
==========================================
  Files         475      475              
  Lines       37955    37965      +10     
==========================================
+ Hits        37250    37259       +9     
- Misses        705      706       +1     
Flag Coverage Δ
integration 98.09% <100.00%> (-0.01%) ⬇️
latest-uploader-overall 98.09% <100.00%> (-0.01%) ⬇️
unit 98.09% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.11% <100.00%> (-0.01%) ⬇️
OutsideTasks 98.10% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
...s/bundle_analysis/notify/contexts/commit_status.py 100.00% <100.00%> (ø)
...otify/contexts/tests/test_commit_status_context.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

This change has been scanned for critical changes. Learn more

Merged via the queue into main with commit 7ebdf9f Sep 11, 2024
26 of 27 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/fix-worker-p8r branch September 11, 2024 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants