Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some type errors in LanguageProcessors #701

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Fix some type errors in LanguageProcessors #701

merged 1 commit into from
Sep 13, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Sep 11, 2024 •
edited
Loading

This only fixes the type errors in one part of the language processors. Others still fail mypy, and I will fix those in followup PRs.

@Swatinem Swatinem self-assigned this Sep 11, 2024
@codecov-notifications
Copy link

codecov-notifications bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.45238% with 11 lines in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files Patch % Lines
services/report/languages/xcode.py 85.36% 6 Missing ⚠️
services/report/languages/mono.py 0.00% 2 Missing ⚠️
services/report/languages/lcov.py 92.30% 1 Missing ⚠️
services/report/languages/pycoverage.py 96.66% 1 Missing ⚠️
services/report/languages/xcodeplist.py 0.00% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         434      434           
  Lines       36548    36607   +59     
=======================================
+ Hits        35852    35911   +59     
  Misses        696      696
Flag Coverage Δ
integration 98.09% <93.45%> (+<0.01%) ⬆️
latest-uploader-overall 98.09% <93.45%> (+<0.01%) ⬆️
unit 98.09% <93.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <93.08%> (+<0.01%) ⬆️
OutsideTasks 98.10% <93.45%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/languages/cobertura.py 98.01% <100.00%> (+1.75%) ⬆️
services/report/languages/helpers.py 100.00% <100.00%> (ø)
services/report/languages/jacoco.py 100.00% <100.00%> (ø)
services/report/languages/lua.py 100.00% <100.00%> (ø)
services/report/languages/scoverage.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_cobertura.py 100.00% <100.00%> (ø)
services/report/languages/tests/unit/test_dlst.py 100.00% <100.00%> (ø)
...uages/tests/unit/test_pycoverage_encoded_labels.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_scoverage.py 100.00% <100.00%> (ø)
services/report/languages/tests/unit/test_vb2.py 100.00% <100.00%> (ø)
... and 8 more

... and 12 files with indirect coverage changes

@codecov-qa
Copy link

codecov-qa bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.45238% with 11 lines in your changes missing coverage. Please review.

Project coverage is 98.09%. Comparing base (ab427f8) to head (e7eb577).
Report is 4 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/report/languages/xcode.py 85.36% 6 Missing ⚠️
services/report/languages/mono.py 0.00% 2 Missing ⚠️
services/report/languages/lcov.py 92.30% 1 Missing ⚠️
services/report/languages/pycoverage.py 96.66% 1 Missing ⚠️
services/report/languages/xcodeplist.py 0.00% 1 Missing ⚠️

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         434      434           
  Lines       36548    36607   +59     
=======================================
+ Hits        35852    35911   +59     
  Misses        696      696
Flag Coverage Δ
integration 98.09% <93.45%> (+<0.01%) ⬆️
latest-uploader-overall 98.09% <93.45%> (+<0.01%) ⬆️
unit 98.09% <93.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <93.08%> (+<0.01%) ⬆️
OutsideTasks 98.10% <93.45%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/report/languages/cobertura.py 98.01% <100.00%> (+1.75%) ⬆️
services/report/languages/helpers.py 100.00% <100.00%> (ø)
services/report/languages/jacoco.py 100.00% <100.00%> (ø)
services/report/languages/lua.py 100.00% <100.00%> (ø)
services/report/languages/scoverage.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_cobertura.py 100.00% <100.00%> (ø)
services/report/languages/tests/unit/test_dlst.py 100.00% <100.00%> (ø)
...uages/tests/unit/test_pycoverage_encoded_labels.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_scoverage.py 100.00% <100.00%> (ø)
services/report/languages/tests/unit/test_vb2.py 100.00% <100.00%> (ø)
... and 8 more

... and 12 files with indirect coverage changes

@codecov-public-qa Codecov Public QA
Copy link

codecov-public-qa bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.45238% with 11 lines in your changes missing coverage. Please review.

Project coverage is 98.09%. Comparing base (ab427f8) to head (e7eb577).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #701   +/-   ##
=======================================
  Coverage   98.09%   98.09%           
=======================================
  Files         434      434           
  Lines       36548    36607   +59     
=======================================
+ Hits        35852    35911   +59     
  Misses        696      696
Flag Coverage Δ
integration 98.09% <93.45%> (+<0.01%) ⬆️
latest-uploader-overall 98.09% <93.45%> (+<0.01%) ⬆️
unit 98.09% <93.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.01% <93.08%> (+<0.01%) ⬆️
OutsideTasks 98.10% <93.45%> (+<0.01%) ⬆️
Files Coverage Δ
services/report/languages/cobertura.py 98.01% <100.00%> (+1.75%) ⬆️
services/report/languages/helpers.py 100.00% <100.00%> (ø)
services/report/languages/jacoco.py 100.00% <100.00%> (ø)
services/report/languages/lua.py 100.00% <100.00%> (ø)
services/report/languages/scoverage.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_cobertura.py 100.00% <100.00%> (ø)
services/report/languages/tests/unit/test_dlst.py 100.00% <100.00%> (ø)
...uages/tests/unit/test_pycoverage_encoded_labels.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_scoverage.py 100.00% <100.00%> (ø)
services/report/languages/tests/unit/test_vb2.py 100.00% <100.00%> (ø)
... and 8 more

... and 12 files with indirect coverage changes

@codecov Codecov
Copy link

codecov bot commented Sep 11, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 93.45238% with 11 lines in your changes missing coverage. Please review.

Project coverage is 98.14%. Comparing base (ab427f8) to head (e7eb577).
Report is 4 commits behind head on main.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
services/report/languages/xcode.py 85.36% 6 Missing ⚠️
services/report/languages/mono.py 0.00% 2 Missing ⚠️
services/report/languages/lcov.py 92.30% 1 Missing ⚠️
services/report/languages/pycoverage.py 96.66% 1 Missing ⚠️
services/report/languages/xcodeplist.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##             main     #701    +/-   ##
========================================
  Coverage   98.13%   98.14%            
========================================
  Files         475      475            
  Lines       37903    38049   +146     
========================================
+ Hits        37198    37343   +145     
- Misses        705      706     +1
Flag Coverage Δ
integration 98.09% <93.45%> (+<0.01%) ⬆️
latest-uploader-overall 98.09% <93.45%> (+<0.01%) ⬆️
unit 98.09% <93.45%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.13% <93.08%> (+0.02%) ⬆️
OutsideTasks 98.10% <93.45%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
services/report/languages/cobertura.py 98.01% <100.00%> (+1.75%) ⬆️
services/report/languages/helpers.py 100.00% <100.00%> (ø)
services/report/languages/jacoco.py 100.00% <100.00%> (ø)
services/report/languages/lua.py 100.00% <100.00%> (ø)
services/report/languages/scoverage.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_cobertura.py 100.00% <100.00%> (ø)
services/report/languages/tests/unit/test_dlst.py 100.00% <100.00%> (ø)
...uages/tests/unit/test_pycoverage_encoded_labels.py 100.00% <100.00%> (ø)
...ices/report/languages/tests/unit/test_scoverage.py 100.00% <100.00%> (ø)
services/report/languages/tests/unit/test_vb2.py 100.00% <100.00%> (ø)
... and 8 more

... and 12 files with indirect coverage changes

Related Entrypoints
run/app.tasks.profiling.normalizer
run/app.tasks.upload.UploadProcessor

@Swatinem Swatinem changed the title Fix type errors in LanguageProcessors Fix some type errors in LanguageProcessors Sep 12, 2024
@Swatinem Swatinem marked this pull request as ready for review September 12, 2024 09:10
@Swatinem Swatinem requested a review from a team September 12, 2024 09:10
@Swatinem Swatinem added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit e867451 Sep 13, 2024
24 of 27 checks passed
@Swatinem Swatinem deleted the swatinem/type-languages branch September 13, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joseph-sentry joseph-sentry joseph-sentry approved these changes

Assignees

@Swatinem Swatinem

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swatinem @joseph-sentry