Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support gh refresh tokens #69

Merged
merged 4 commits into from
Sep 5, 2023
Merged

Conversation

giovanni-guidini
Copy link
Contributor

Depends on codecov/shared#27
TODO: after that is merged update the sha reference in requirements.in

Adds support for github app refresh tokens

codecov/engineering-team#162

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Aug 28, 2023

Codecov Report

Merging #69 (1c0c945) into main (eef11ba) will decrease coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 1c0c945 differs from pull request most recent head ed0fc28. Consider uploading reports for the commit ed0fc28 to get more accurate results

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #69      +/-   ##
==========================================
- Coverage   98.47%   98.47%   -0.01%     
==========================================
  Files         361      361              
  Lines       26477    26456      -21     
==========================================
- Hits        26073    26052      -21     
  Misses        404      404              
Flag Coverage Δ
integration ?
latest-uploader-overall ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 97.12% <ø> (-0.01%) ⬇️
OutsideTasks 98.27% <ø> (-0.01%) ⬇️
Files Changed Coverage Δ
conftest.py 94.40% <ø> (-0.05%) ⬇️
services/owner.py 100.00% <ø> (ø)
services/repository.py Critical 96.72% <ø> (-0.27%) ⬇️
services/tests/test_repository_service.py 99.74% <ø> (-0.01%) ⬇️

... and 1 file with indirect coverage changes

Related Entrypoints
run/app.tasks.upload.UploadProcessor
run/app.tasks.notify.Notify
run/app.tasks.compute_comparison.ComputeComparison
run/app.tasks.upload.Upload
run/app.tasks.status.SetError
run/app.tasks.pulls.Sync
run/app.tasks.commit_update.CommitUpdate
run/app.tasks.label_analysis.process_request

Copy link
Contributor

@dana-yaish dana-yaish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but would love to know what others think of this

Depends on codecov/shared#27
TODO: after that is merged update the sha reference in requirements.in

Adds support for github app refresh tokens

codecov/engineering-team#162
* Updates shared to a newer version
* Adds a on_token_refresh callback if the torngit adapter comes from owner.py

context codecov/engineering-team#162
@giovanni-guidini giovanni-guidini merged commit a4b846e into main Sep 5, 2023
8 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/gh-refresh-token branch September 5, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants