-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support gh refresh tokens #69
Conversation
069f06d
to
93ea61a
Compare
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #69 +/- ##
==========================================
- Coverage 98.47% 98.47% -0.01%
==========================================
Files 361 361
Lines 26477 26456 -21
==========================================
- Hits 26073 26052 -21
Misses 404 404
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes
|
2fc4026
to
38b864e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but would love to know what others think of this
Depends on codecov/shared#27 TODO: after that is merged update the sha reference in requirements.in Adds support for github app refresh tokens codecov/engineering-team#162
* Updates shared to a newer version * Adds a on_token_refresh callback if the torngit adapter comes from owner.py context codecov/engineering-team#162
38b864e
to
f22e5f5
Compare
73a76ab
to
1c0c945
Compare
Depends on codecov/shared#27
TODO: after that is merged update the sha reference in requirements.in
Adds support for github app refresh tokens
codecov/engineering-team#162
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.