Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add server_default value to avoid null tokens #680

Merged
merged 1 commit into from
Sep 3, 2024

Conversation

adrian-codecov
Copy link
Contributor

The revert of this PR, #678. Additional change includes adding a server_default=FetchedValue() to prevent upload_tokens having a null value

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         434      434           
  Lines       36721    36728    +7     
=======================================
+ Hits        36015    36022    +7     
  Misses        706      706           
Flag Coverage Δ
integration 98.07% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+<0.01%) ⬆️
unit 98.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.96% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.07% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/events.py 94.44% <100.00%> (+0.69%) ⬆️
database/models/core.py 97.77% <100.00%> (+<0.01%) ⬆️
database/tests/unit/test_events.py 100.00% <100.00%> (ø)

@codecov-qa
Copy link

codecov-qa bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (9078de2) to head (deac944).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         434      434           
  Lines       36721    36728    +7     
=======================================
+ Hits        36015    36022    +7     
  Misses        706      706           
Flag Coverage Δ
integration 98.07% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+<0.01%) ⬆️
unit 98.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.96% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.07% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/events.py 94.44% <100.00%> (+0.69%) ⬆️
database/models/core.py 97.77% <100.00%> (+<0.01%) ⬆️
database/tests/unit/test_events.py 100.00% <100.00%> (ø)

Copy link

codecov-public-qa bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.07%. Comparing base (9078de2) to head (deac944).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   98.07%   98.07%           
=======================================
  Files         434      434           
  Lines       36721    36728    +7     
=======================================
+ Hits        36015    36022    +7     
  Misses        706      706           
Flag Coverage Δ
integration 98.07% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+<0.01%) ⬆️
unit 98.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 95.96% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.07% <100.00%> (+<0.01%) ⬆️
Files Coverage Δ
database/events.py 94.44% <100.00%> (+0.69%) ⬆️
database/models/core.py 97.77% <100.00%> (+<0.01%) ⬆️
database/tests/unit/test_events.py 100.00% <100.00%> (ø)

Copy link

codecov bot commented Sep 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.12%. Comparing base (9078de2) to head (deac944).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #680   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         474      474           
  Lines       38047    38054    +7     
=======================================
+ Hits        37333    37340    +7     
  Misses        714      714           
Flag Coverage Δ
integration 98.07% <100.00%> (+<0.01%) ⬆️
latest-uploader-overall 98.07% <100.00%> (+<0.01%) ⬆️
unit 98.07% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.07% <100.00%> (+<0.01%) ⬆️
OutsideTasks 98.07% <100.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
database/events.py 94.44% <100.00%> (+0.69%) ⬆️
database/models/core.py 97.77% <100.00%> (+<0.01%) ⬆️
database/tests/unit/test_events.py 100.00% <100.00%> (ø)

This change has been scanned for critical changes. Learn more

@adrian-codecov adrian-codecov added this pull request to the merge queue Sep 3, 2024
Merged via the queue into main with commit 2055b30 Sep 3, 2024
25 of 26 checks passed
@adrian-codecov adrian-codecov deleted the 170-3-adjust-event-only-to-fire-when-due branch September 3, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants