Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ezpz: downgrade checkpoint logger errors to warnings #68

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

matt-codecov
Copy link
Contributor

deployed with error severity to loudly flag whether the UploadFlow logs were hooked up right. downgrading to warning to lessen noise for support folks

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Aug 16, 2023

Codecov Report

Merging #68 (6196775) into main (5df32f9) will decrease coverage by 0.33%.
The diff coverage is 0.00%.

Changes have been made to critical files, which contain lines commonly executed in production. Learn more

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #68      +/-   ##
==========================================
- Coverage   98.59%   98.26%   -0.33%     
==========================================
  Files         359      359              
  Lines       26275    26275              
==========================================
- Hits        25905    25819      -86     
- Misses        370      456      +86     
Flag Coverage Δ
latest-uploader-overall ?
onlysomelabels 98.26% <0.00%> (-0.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 96.98% <0.00%> (-0.32%) ⬇️
OutsideTasks 98.37% <0.00%> (-0.02%) ⬇️
Files Changed Coverage Δ
helpers/checkpoint_logger.py 98.33% <0.00%> (ø)

... and 8 files with indirect coverage changes

This change has been scanned for critical changes. Learn more

@matt-codecov matt-codecov merged commit 6be055d into main Aug 17, 2023
9 of 12 checks passed
@matt-codecov matt-codecov deleted the matt/checkpoint-logger-warning branch August 17, 2023 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants