fix: use strings as webhook secrets #66
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
giovanni-guidini
force-pushed
the
gio/use-uuid-as-string
branch
from
84a49fd
to
91a4ce6
Compare
Codecov Report
Changes have been made to critical files, which contain lines commonly executed in production. Learn more @@ Coverage Diff @@
## main #66 +/- ##
=======================================
Coverage 98.59% 98.59%
=======================================
Files 357 357
Lines 26004 26004
=======================================
Hits 25639 25639
Misses 365 365
Flags with carried forward coverage won't be shown. Click here to find out more.
This change has been scanned for critical changes. Learn more |
Fix https://codecov.sentry.io/share/issue/ef92212e1461452c90a16ae188e9c00b/ We were creating UUID4 webhook secrets per repo for gitlab and gitlab-enterprise. When logging the body of the request the json decoder would crash.
giovanni-guidini
force-pushed
the
gio/use-uuid-as-string
branch
from
91a4ce6
to
b02d2bb
Compare
scott-codecov
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix https://codecov.sentry.io/share/issue/ef92212e1461452c90a16ae188e9c00b/
We were creating UUID4 webhook secrets per repo for gitlab and gitlab-enterprise.
When logging the body of the request the json decoder would crash.
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.