show patch coverage only for changed files, and don't show indirect changed files #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #60 +/- ##
==========================================
- Coverage 98.61% 98.60% -0.01%
==========================================
Files 357 357
Lines 25943 25967 +24
==========================================
+ Hits 25584 25606 +22
- Misses 359 361 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
|
giovanni-guidini
approved these changes
Aug 15, 2023
| @@ -464,11 +467,13 @@ async def do_write_section(self, comparison, diff, changes, links, behind_by=Non | |||
| head_report = comparison.head.report | |||
| if base_report is None: | |||
| base_report = Report() | |||
| hide_project_coverage = self.settings.get("hide_project_coverage", False) | |||
| metrics = get_metrics_method(hide_project_coverage) | |||
There was a problem hiding this comment.
[nit] I think make_metrics_fn would be a better name than metrics
| return "".join(("|", coverage)) | ||
|
|
||
|
|
||
| def get_metrics_method(hide_project_coverage): |
There was a problem hiding this comment.
[very nit] I think that technically both make_patch_only_metrics and make_metrics are functions, not methods
| @@ -116,6 +116,53 @@ def make_metrics(before, after, relative, show_complexity, yaml): | |||
| return "".join(("|", coverage, complexity, icon)) | |||
|
|
|||
|
|
|||
| def make_patch_only_metrics(before, after, relative, show_complexity, yaml): | |||
| if after is None: | |||
| # e.g. missing flags | |||
There was a problem hiding this comment.
Thank you for these helpful comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want to show patch coverage only in the changed files table, and hide any indirect changed files
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.