Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update shared, fixing BundleAnalysisReport connection leak #589

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

Swatinem
Copy link
Contributor

@Swatinem Swatinem commented Aug 5, 2024

This primarily pulls in codecov/shared#309, which fixes an error related to BundleAnalysisReport keeping a SQLite connection open without properly closing it.

This primarily pulls in codecov/shared#309, which fixes an error related to `BundleAnalysisReport` keeping a SQLite connection open without properly closing it.
@Swatinem Swatinem self-assigned this Aug 5, 2024
@codecov-qa
Copy link

codecov-qa bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (8d8882d) to head (2205e4a).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         421      421           
  Lines       35244    35244           
=======================================
  Hits        34374    34374           
  Misses        870      870           
Flag Coverage Δ
integration 97.53% <ø> (ø)
latest-uploader-overall 97.53% <ø> (ø)
unit 97.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.64% <ø> (ø)
OutsideTasks 97.75% <ø> (ø)

Copy link

codecov-public-qa bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (8d8882d) to head (2205e4a).

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         421      421           
  Lines       35244    35244           
=======================================
  Hits        34374    34374           
  Misses        870      870           
Flag Coverage Δ
integration 97.53% <ø> (ø)
latest-uploader-overall 97.53% <ø> (ø)
unit 97.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.64% <ø> (ø)
OutsideTasks 97.75% <ø> (ø)

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         421      421           
  Lines       35244    35244           
=======================================
  Hits        34374    34374           
  Misses        870      870           
Flag Coverage Δ
integration 97.53% <ø> (ø)
latest-uploader-overall 97.53% <ø> (ø)
unit 97.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.64% <ø> (ø)
OutsideTasks 97.75% <ø> (ø)

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.57%. Comparing base (8d8882d) to head (2205e4a).

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #589   +/-   ##
=======================================
  Coverage   97.57%   97.57%           
=======================================
  Files         456      456           
  Lines       36450    36450           
=======================================
  Hits        35566    35566           
  Misses        884      884           
Flag Coverage Δ
integration ?
latest-uploader-overall 97.53% <ø> (ø)
unit 97.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
NonTestCode 94.72% <ø> (ø)
OutsideTasks 97.75% <ø> (ø)

This change has been scanned for critical changes. Learn more

@Swatinem Swatinem added this pull request to the merge queue Aug 5, 2024
Merged via the queue into main with commit 6efd4b5 Aug 5, 2024
26 checks passed
@Swatinem Swatinem deleted the swatinem/update-shared branch August 5, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants