Change names of path_fixes to report_fixes #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 98.46% 98.46%
=======================================
Files 369 369
Lines 27233 27233
=======================================
Hits 26814 26814
Misses 419 419
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
force-pushed
the
joseph/rename-path-fixes
branch
4 times, most recently
from
74e2fc3
to
534dac7
Compare
|
@giovanni-guidini @dana-yaish Is it worth it to change the string that we expect here: https://github.com/codecov/worker/pull/58/files#diff-1d8567e678087007495cf44619eec19e7325fe7b1106110b56d68c96c14ef7e1R27 , changing it would mean it's correct now, but this would break old versions of the CLI |
joseph-sentry
force-pushed
the
joseph/rename-path-fixes
branch
from
534dac7
to
4678cde
Compare
|
@joseph-sentry is this still being worked on? |
this is ready for another review |
joseph-sentry
force-pushed
the
joseph/rename-path-fixes
branch
from
4678cde
to
94d557f
Compare
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 346 346
Lines 26889 26889
=======================================
Hits 25075 25075
Misses 1814 1814
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 346 346
Lines 26889 26889
=======================================
Hits 25075 25075
Misses 1814 1814
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Codecov Report
@@ Coverage Diff @@
## main #58 +/- ##
=======================================
Coverage 93.25% 93.25%
=======================================
Files 346 346
Lines 26889 26889
=======================================
Hits 25075 25075
Misses 1814 1814
Flags with carried forward coverage won't be shown. Click here to find out more.
|
joseph-sentry
force-pushed
the
joseph/rename-path-fixes
branch
from
94d557f
to
1630411
Compare
giovanni-guidini
approved these changes
Oct 3, 2023
| @@ -26,26 +26,43 @@ def get_first_line(self): | |||
|
|
|||
|
|
|||
| class ParsedRawReport(object): | |||
| """ | |||
| Parsed raw report parent class | |||
There was a problem hiding this comment.
This is very helpful 👍 thanks for doing this
| @@ -24,10 +24,15 @@ def parse_raw_report_from_bytes(self, raw_report: bytes): | |||
| uploaded_files=[ | |||
| self._parse_single_coverage_file(x) for x in data["coverage_files"] | |||
| ], | |||
| path_fixes=self._parse_path_fixes(data["path_fixes"]), | |||
| report_fixes=self._parse_report_fixes( | |||
| # want backwards compatibility with older versions of the CLI that still name this section path_fixes | |||
There was a problem hiding this comment.
10/10 - This is very good. Yes we do want that.
This commit changes the name of the path_fixes section in the ParsedRawReport classes to report_fixes. For more information on report fixes: https://docs.codecov.com/docs/fixing-reports For more information on path fixes: https://docs.codecov.com/docs/fixing-paths Signed-off-by: joseph-sentry <[email protected]>
joseph-sentry
force-pushed
the
joseph/rename-path-fixes
branch
from
1630411
to
423cf9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the name of the path_fixes
section in the ParsedRawReport classes to report_fixes.
For more information on report fixes:
https://docs.codecov.com/docs/fixing-reports
For more information on path fixes:
https://docs.codecov.com/docs/fixing-paths
Fixes: codecov/codecov-cli#207